Skip to content

Request.finish() may pass useless string to MarkerLog #115

@joebowbeer

Description

@joebowbeer

In Request.finish(), the Runnable is calling toString on itself instead of the Request object:

    mainThread.post(new Runnable() {
        @Override
        public void run() {
            mEventLog.add(tag, threadId);
            mEventLog.finish(this.toString());
        }
    });

Should be Request.this.toString()

Also, it would be more robust and leak-resistant if this Runnable were a static nested class that held no reference to the outer Request instance.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions