Added job manager class#248
Conversation
aarontp
left a comment
There was a problem hiding this comment.
Nice. I like this pattern, and this makes things a lot cleaner. Just a couple small things. Thanks!
| @@ -0,0 +1,123 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
I think we might need the copyright blurb here?
There was a problem hiding this comment.
Done, though I'm not sure we actually need the copyright notice in every file. I know this changed at some point in the past for Plaso, for example.
| self.assertIsNotNone(job) | ||
| self.assertEqual(job.NAME, 'testjob1') | ||
|
|
||
| job = manager.JobsManager.GetJobInstance('testjob1') |
There was a problem hiding this comment.
Not sure what intended here, removed.
|
|
||
| def testGetJobInstances(self): | ||
| """Tests getting job objects by name.""" | ||
| job_names = manager.JobsManager.GetJobNames() |
There was a problem hiding this comment.
Shouldn't we add a job or two first to really test this?
There was a problem hiding this comment.
That is definitely more useful.
|
|
||
|
|
||
| class SSHDExtractionJob(TurbiniaJob): | ||
| class SSHDExtractionJob(interface.TurbiniaJob): |
There was a problem hiding this comment.
Don't we need to set a NAME for this Job as well?
|
Did your changes get pushed? I don't see them in the commit list or the diff. |
* Docker & Wordpress * Cleanup * Fix reviewer comments * Rename classes & address reviewer comments. * Fix reviewer comments + add support for gzipped files * Fix ugly logs * Fix broken text
* Change wordpress task so tests run deterministically * Sort list before returning rather than changing data type
* Scaffolding for Jenkins analysis * Add analysis and tests * Linter happy * Allow more input evidence * Add import of JenkinsAnalysisJob
* Set status and fix linting in jenkins task
* empty shell * more scaffholding * make all of this more simple * Things appear to be working * typo * undo some filepath manipulations * register the new hadoop Job * cleanup * renamed * fix output evidence * add tests * typo * styleguide * full path to strings * comments * sync * fix tests * fix py3 tests * fix py3 harder * I call this 'bruteforce programming' * Make _AnalyzeHadoopAppRoot return a list of string, to use the first one as status on the result Evidence * remove extra tab * also check at the beggining of the line
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
Closing this out, as the git history got screwed up. |
This was inspired by some recent conversations, and #247 - this is manager class for handling job registration. We use a similar scheme in Plaso, and it's been a pretty good model for handling different sorts of subcomponent management (registration/deregistration, enabling/disabling).
This should go in after #240 and #226 so we don't complicate things. Putting it out now for discussion in advance.