Add instructions for using docker to regen derived files#3489
Merged
mhutchinson merged 2 commits intogoogle:masterfrom May 9, 2024
Merged
Add instructions for using docker to regen derived files#3489mhutchinson merged 2 commits intogoogle:masterfrom
mhutchinson merged 2 commits intogoogle:masterfrom
Conversation
This is much cleaner than the previous approach of requiring protoc to be installed globally on the machine, which inevitably causes tensions with other projects that are developed on the same machine. We may want to consider building and publishing the Docker image in a repository so that people can just pull it and use it unless they are upgrading any of the tool versions (e.g. protoc).
phbnf
reviewed
May 8, 2024
roger2hk
reviewed
May 8, 2024
phbnf
approved these changes
May 8, 2024
roger2hk
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is much cleaner than the previous approach of requiring protoc to be installed globally on the machine, which inevitably causes tensions with other projects that are developed on the same machine. We may want to consider building and publishing the Docker image in a repository so that people can just pull it and use it unless they are upgrading any of the tool versions (e.g. protoc).