Skip to content

Replace deprecated prune-whitelist flag with prune-allowlist for kubectl command#3307

Merged
roger2hk merged 1 commit intogoogle:masterfrom
roger2hk:kubectl-prune-list
Apr 22, 2024
Merged

Replace deprecated prune-whitelist flag with prune-allowlist for kubectl command#3307
roger2hk merged 1 commit intogoogle:masterfrom
roger2hk:kubectl-prune-list

Conversation

@roger2hk
Copy link
Copy Markdown
Contributor

@roger2hk roger2hk commented Jan 21, 2024 •
edited
Loading

Warning message from the Google Cloud Build:

Step #10 - "apply_k8s_cfgs_for_mysql_dryrun": Running: kubectl apply --dry-run=server --namespace=mysql -f=envsubst-mysql/etcd-cluster.yaml -f=envsubst-mysql/trillian-ci-mysql.yaml -f=envsubst-mysql/trillian-mysql.yaml -f=envsubst-mysql/trillian-log-deployment.yaml -f=envsubst-mysql/trillian-log-service.yaml -f=envsubst-mysql/trillian-log-signer-deployment.yaml -f=envsubst-mysql/trillian-log-signer-service.yaml --prune --all --prune-whitelist=core/v1/ConfigMap
Step #10 - "apply_k8s_cfgs_for_mysql_dryrun": Flag --prune-whitelist has been deprecated, Use --prune-allowlist instead.

Checklist

@roger2hk
Copy link
Copy Markdown
Contributor Author

roger2hk commented Jan 23, 2024 •
edited
Loading

trillian-pr-deploy (trillian-opensource-ci) is failed due to the deprecated GKE version running behind the scene.

Step #10 - "apply_k8s_cfgs_for_mysql_dryrun": Running: kubectl apply --dry-run=server --namespace=mysql -f=envsubst-mysql/etcd-cluster.yaml -f=envsubst-mysql/trillian-ci-mysql.yaml -f=envsubst-mysql/trillian-mysql.yaml -f=envsubst-mysql/trillian-log-deployment.yaml -f=envsubst-mysql/trillian-log-service.yaml -f=envsubst-mysql/trillian-log-signer-deployment.yaml -f=envsubst-mysql/trillian-log-signer-service.yaml --prune --all --prune-allowlist=core/v1/ConfigMap
Step #10 - "apply_k8s_cfgs_for_mysql_dryrun": error: unknown flag: --prune-allowlist

kubernetes/kubernetes#113116

@roger2hk roger2hk marked this pull request as ready for review April 19, 2024 22:03
@roger2hk roger2hk requested a review from a team as a code owner April 19, 2024 22:03
@roger2hk
Copy link
Copy Markdown
Contributor Author

roger2hk commented Apr 19, 2024

The GKE version is now 1.26 in GCP, so the check is now passed.

@roger2hk roger2hk merged commit 847b10f into google:master Apr 22, 2024
@roger2hk roger2hk deleted the kubectl-prune-list branch April 22, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phbnf phbnf phbnf approved these changes

@mhutchinson mhutchinson Awaiting requested review from mhutchinson

@AlCutter AlCutter Awaiting requested review from AlCutter

+1 more reviewer

@JAORMX JAORMX JAORMX approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roger2hk @JAORMX @phbnf