This repository was archived by the owner on Oct 24, 2025. It is now read-only.
Merged
Conversation
Requires interior mutability for HeaderIntegrityFetcher, so that a fine-grained lock can be held for just the mutable HttpCache, without blocking access to the immutable Fetcher in parallel. Added a unit test that the operation completes when fetches are returned out of order.
9bc8980 to
fd8b26b
Compare
banaag
reviewed
Sep 16, 2021
banaag
approved these changes
Sep 16, 2021
antiphoton
approved these changes
Sep 16, 2021
1dc8514 to
c22186f
Compare
Add a test that demonstrates cache.get calls resolving out of order, and fix it by requiring interior mutability for HttpCache, and removing RefCell.
antiphoton
approved these changes
Sep 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires interior mutability for HeaderIntegrityFetcher, so that a fine-grained
lock can be held for just the mutable HttpCache, without blocking access to the
immutable Fetcher in parallel.
Added a unit test that the operation completes when fetches are returned out of
order.
Fixes #13.
/cc @oliy