Disable QCOM_tiled_rendering while we wait for test devices

csmartdalton86 · heathmill · commit a640745ce52e · 2020-01-15T21:08:59.000Z
There are devices that advertise this extension but don't actually provide the GL entrypoints. This is causing live crashes. Bug: flutter:47164 Bug: flutter:47804 Change-Id: Idded47e8dbd4462463ad91a62b06b0df3245f0c1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/263809 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com> (cherry picked from commit 0a1923e) Reviewed-on: https://skia-review.googlesource.com/c/skia/+/264641
diff --git a/src/gpu/gl/GrGLCaps.cpp b/src/gpu/gl/GrGLCaps.cpp
@@ -681,9 +681,11 @@ void GrGLCaps::init(const GrContextOptions& contextOptions,
         fSamplerObjectSupport = version >= GR_GL_VER(2,0);
     }
 
-    if (GR_IS_GR_GL_ES(standard)) {
-        fTiledRenderingSupport = ctxInfo.hasExtension("GL_QCOM_tiled_rendering");
-    }
+    // https://github.com/flutter/flutter/issues/47164
+    // https://github.com/flutter/flutter/issues/47804
+    // if (GR_IS_GR_GL_ES(standard)) {
+    //     fTiledRenderingSupport = ctxInfo.hasExtension("GL_QCOM_tiled_rendering");
+    // }
 
     FormatWorkarounds formatWorkarounds;
 
diff --git a/src/gpu/gl/GrGLInterfaceAutogen.cpp b/src/gpu/gl/GrGLInterfaceAutogen.cpp
@@ -335,10 +335,7 @@ bool GrGLInterface::validate() const {
 
     if ((GR_IS_GR_GL_ES(fStandard) && (
           fExtensions.has("GL_QCOM_tiled_rendering")))) {
-        if (!fFunctions.fEndTiling ||
-            !fFunctions.fStartTiling) {
-            RETURN_FALSE_INTERFACE;
-        }
+        // all functions were marked optional or test_only
     }
 
     if ((GR_IS_GR_GL(fStandard) && (
diff --git a/tools/gpu/gl/interface/interface.json5 b/tools/gpu/gl/interface/interface.json5
@@ -271,6 +271,11 @@
 
     "functions": [
       "StartTiling", "EndTiling",
+    ],
+    // https://github.com/flutter/flutter/issues/47164
+    // https://github.com/flutter/flutter/issues/47804
+    "optional": [
+      "StartTiling", "EndTiling",
     ]
   },
 
