Skip to content

Change AMP GA opt-out to use meta tag#3593

Merged
felixarntz merged 1 commit intodevelopfrom
fix/3572-web-stories-validation
Jun 17, 2021
Merged

Change AMP GA opt-out to use meta tag#3593
felixarntz merged 1 commit intodevelopfrom
fix/3572-web-stories-validation

Conversation

@aaemnnosttv
Copy link
Copy Markdown
Collaborator

@aaemnnosttv aaemnnosttv commented Jun 17, 2021

Summary

Addresses issue #3572

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@google-cla google-cla bot added the cla: yes label Jun 17, 2021
@aaemnnosttv aaemnnosttv mentioned this pull request Jun 17, 2021
Closed
felixarntz
felixarntz approved these changes Jun 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@felixarntz felixarntz merged commit cf50610 into develop Jun 17, 2021
@felixarntz felixarntz deleted the fix/3572-web-stories-validation branch June 17, 2021 16:14
@aaemnnosttv aaemnnosttv mentioned this pull request Jun 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@felixarntz felixarntz felixarntz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aaemnnosttv @felixarntz