Skip to content

Enhancement/12519 replace tour missing steps#12725

Merged
hussain-t merged 6 commits into
developfrom
enhancement/12519-replace-tour-missing-steps
May 20, 2026
Merged

Enhancement/12519 replace tour missing steps#12725
hussain-t merged 6 commits into
developfrom
enhancement/12519-replace-tour-missing-steps

Conversation

@abdelmalekkkkk

@abdelmalekkkkk abdelmalekkkkk commented May 14, 2026 •
edited by hussain-t
Loading

Copy link
Copy Markdown
Contributor

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions

github-actions Bot commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 This comment is automatically updated by CI workflows. Each section is managed independently.

📦 Build files for 6800b57:

  • Build files have been deleted.

🎭 Playwright reports for 6800b57:

  • Reports have been deleted.

📚 Storybook for 6800b57:

  • Storybook has been deleted.

@github-actions

github-actions Bot commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 2.37 MB

ℹ️ View Unchanged
Filename Size Change
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css 124 B 0 B
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/index.js 42.7 kB 0 B
dist/assets/blocks/reader-revenue-manager/common/editor-styles.css 307 B 0 B
dist/assets/blocks/reader-revenue-manager/common/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/reader-revenue-manager/contribute-with-google/index.js 5.81 kB 0 B
dist/assets/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js 5 kB 0 B
dist/assets/blocks/reader-revenue-manager/subscribe-with-google/index.js 5.81 kB 0 B
dist/assets/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js 5 kB 0 B
dist/assets/blocks/sign-in-with-google/editor-styles.css 84 B 0 B
dist/assets/blocks/sign-in-with-google/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/sign-in-with-google/index.js 18.5 kB 0 B
dist/assets/css/googlesitekit-admin-css-********************.min.css 70 kB 0 B
dist/assets/css/googlesitekit-adminbar-css-********************.min.css 12.3 kB 0 B
dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 851 B 0 B
dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.88 kB 0 B
dist/assets/js/146-********************.js 960 B 0 B
dist/assets/js/201-********************.js 2.85 kB 0 B
dist/assets/js/273-********************.js 52.5 kB 0 B
dist/assets/js/314-********************.js 100 kB 0 B
dist/assets/js/315-********************.js 3.08 kB 0 B
dist/assets/js/379-********************.js 3.7 kB 0 B
dist/assets/js/590-********************.js 1.88 kB 0 B
dist/assets/js/640-********************.js 2.35 kB 0 B
dist/assets/js/909-********************.js 1.01 kB 0 B
dist/assets/js/analytics-advanced-tracking-********************.js 404 B 0 B
dist/assets/js/googlesitekit-activation-********************.js 24.9 kB 0 B
dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 60.6 kB +139 B (+0.23%)
dist/assets/js/googlesitekit-admin-pointers-tracking-********************.js 5.36 kB 0 B
dist/assets/js/googlesitekit-adminbar-********************.js 36 kB 0 B
dist/assets/js/googlesitekit-api-********************.js 8.04 kB 0 B
dist/assets/js/googlesitekit-block-tracking-********************.js 5.56 kB 0 B
dist/assets/js/googlesitekit-components-********************.js 5.63 kB 0 B
dist/assets/js/googlesitekit-consent-mode-********************.js 25.5 kB 0 B
dist/assets/js/googlesitekit-data-********************.js 1.76 kB 0 B
dist/assets/js/googlesitekit-datastore-forms-********************.js 7.21 kB 0 B
dist/assets/js/googlesitekit-datastore-location-********************.js 1.52 kB 0 B
dist/assets/js/googlesitekit-datastore-site-********************.js 18.7 kB +18 B (+0.1%)
dist/assets/js/googlesitekit-datastore-ui-********************.js 7.37 kB 0 B
dist/assets/js/googlesitekit-datastore-user-********************.js 23.1 kB 0 B
dist/assets/js/googlesitekit-entity-dashboard-********************.js 73.9 kB +152 B (+0.21%)
dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 1.23 kB 0 B
dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 629 B 0 B
dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 1.22 kB 0 B
dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 1.22 kB 0 B
dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 1.25 kB 0 B
dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 1.29 kB 0 B
dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 918 B 0 B
dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 1.25 kB 0 B
dist/assets/js/googlesitekit-i18n-********************.js 6.1 kB 0 B
dist/assets/js/googlesitekit-key-metrics-setup-********************.js 54 kB +145 B (+0.27%)
dist/assets/js/googlesitekit-main-dashboard-********************.js 167 kB +153 B (+0.09%)
dist/assets/js/googlesitekit-metric-selection-********************.js 59.8 kB +138 B (+0.23%)
dist/assets/js/googlesitekit-modules-********************.js 26 kB 0 B
dist/assets/js/googlesitekit-modules-ads-********************.js 48 kB +19 B (+0.04%)
dist/assets/js/googlesitekit-modules-adsense-********************.js 138 kB +136 B (+0.1%)
dist/assets/js/googlesitekit-modules-analytics-4-********************.js 193 kB +50 B (+0.03%)
dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 23.3 kB 0 B
dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 52.6 kB 0 B
dist/assets/js/googlesitekit-modules-search-console-********************.js 65.3 kB 0 B
dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 33.8 kB 0 B
dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30.2 kB 0 B
dist/assets/js/googlesitekit-notifications-********************.js 66.7 kB 0 B
dist/assets/js/googlesitekit-polyfills-********************.js 228 B 0 B
dist/assets/js/googlesitekit-settings-********************.js 135 kB +139 B (+0.1%)
dist/assets/js/googlesitekit-splash-********************.js 80 kB +134 B (+0.17%)
dist/assets/js/googlesitekit-user-input-********************.js 52.2 kB +141 B (+0.27%)
dist/assets/js/googlesitekit-vendor-********************.js 315 kB 0 B
dist/assets/js/googlesitekit-widgets-********************.js 104 kB 0 B
dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.6 kB 0 B
dist/assets/js/runtime-********************.js 1.89 kB 0 B

compressed-size-action

@shervElmi shervElmi mentioned this pull request May 19, 2026
Closed
4 tasks
hussain-t
hussain-t requested changes May 19, 2026
View reviewed changes

@hussain-t hussain-t left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @abdelmalekkkkk! Overall, the changes look good. However, I've left a few comments. Please take a look and resolve the merge conflicts from the latest develop.

Comment thread assets/js/feature-tours/hooks/useWelcomeTour.ts Outdated
Comment thread assets/js/feature-tours/hooks/useWelcomeTour.ts Outdated
Comment thread assets/js/feature-tours/hooks/useWelcomeTour.ts Outdated
@abdelmalekkkkk abdelmalekkkkk force-pushed the enhancement/12519-replace-tour-missing-steps branch from 4fb7143 to 9dde124 Compare May 19, 2026 12:47
@abdelmalekkkkk

abdelmalekkkkk commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @hussain-t. Back to you for another pass.

hussain-t
hussain-t requested changes May 20, 2026
View reviewed changes

@hussain-t hussain-t left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback, @abdelmalekkkkk! However, I found a potential bug while testing it. Please take a look at my comments.

Comment thread assets/js/feature-tours/hooks/useWelcomeTour.ts Outdated
Comment thread assets/js/feature-tours/hooks/useWelcomeTour.ts Outdated
@abdelmalekkkkk

abdelmalekkkkk commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @hussain-t! I addressed that bug. I also renamed the options since it's no longer just about those features being set up, and added test coverage for that scenario. Please take another look.

hussain-t
hussain-t reviewed May 20, 2026
View reviewed changes
Comment thread assets/js/feature-tours/hooks/useWelcomeTour.test.ts Outdated
hussain-t
hussain-t approved these changes May 20, 2026
View reviewed changes

@hussain-t hussain-t left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @abdelmalekkkkk! LGTM 👍

Note: I've verified that the CI build failures are unrelated to this PR.

@hussain-t hussain-t merged commit b6892ca into develop May 20, 2026
30 of 31 checks passed
@hussain-t hussain-t deleted the enhancement/12519-replace-tour-missing-steps branch May 20, 2026 14:37
@hussain-t hussain-t mentioned this pull request May 20, 2026
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hussain-t hussain-t hussain-t approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abdelmalekkkkk @hussain-t