Bug Description

This is regarding the feature tour implemented under SFR.
For a view-only user who doesn't have Analytics access, the tour starts and ends with the 5/5 tooltip.
This definitely needs to be fixed but how to fix it might need some discussion.

Here are some food for thought:
If we have only one tooltip to display, does it count as a tour? In the case, should we just hide the tour feature from the help menu?
However, that wouldn't address the tour from the welcome modal.

Video is attached for reference further down, in the 'Screenshots' section.

Steps to reproduce

1. Set up Site Kit with Analytics connected and the setupFlowRefresh feature flag enabled.
2. Share just the Search Console module with a view-only user.
3. Login as the view-only user and trigger the feature tour.
4. See the tour start and end with the dashboard sharing step, showing 5/5 for its progress.

Screenshots

Additional Context

• PHP Version:
• OS: [e.g. iOS]
• Browser: [e.g. chrome, safari]
• Plugin Version: [e.g. 22]
• Device: [e.g. iPhone6]

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• If a view-only user doesn't have access to both the Analytics and Search Console modules, we don't have a tour to show. In this scenario:
  • The Welcome modal is not shown when first landing on the dashboard.
  • The Help menu does not show the "Start a feature tour" button.
• If Analytics is connected, but the view-only user only has access to the Search Console module:
  • The Search Console-only dashboard tour is shown when triggering the tour from Welcome modal or the Help menu.

Implementation Brief

• Rename assets/js/googlesitekit/datastore/user/welcome-modal.ts to assets/js/googlesitekit/datastore/user/setup-flow.ts. In this file:
  • Create a new selector called hasAccessToFeatureTour(), which returns true when the user has access to either the Analytics or the Search Console module.
    • Use the hasAccessToShareableModule() selector to check module access.
  • Rename isAnalyticsConnected to isAnalyticsViewable throughout the file.
• In assets/js/components/DashboardMainApp.js:
  • Use the new hasAccessToFeatureTour() selector to determine whether to show the Welcome modal and the Start a feature tour button in the Help menu.
• In assets/js/feature-tours/hooks/useWelcomeTour.ts:
  • Rename the isAnalyticsConnected constant to isAnalyticsViewable, and update the associated useSelect() callback to return true when Analytics is both connected and viewable.
    • Use the isModuleConnected() and hasAccessToShareableModule() selectors to check if Analytics is connected and viewable.

Test Coverage

• Add test coverage for the new hasAccessToFeatureTour() selector.
• Update the tests for useWelcomeTour() to cover the above changes.

QA Brief

• Follow the steps to reproduce and ensure that the bug no longer occurs.
• Verify that the ACs are met.

Changelog entry

• Fix the dashboard tour showing incorrect steps for view-only users without Analytics access.