This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Add a Signing ID Format Helper #1365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlw
reviewed
Jun 10, 2024
Contributor
mlw
left a comment
There was a problem hiding this comment.
I think it would be more powerful if things like SID were made into their own type. Having a helper is nice, but there's no format enforcement mechanism by keeping it a string.
Contributor
Agree in principle but they'll be strings coming in from MOLCodesignChecker and need to be converted back to strings in several other places (syncservice, event database) so the type is only going to ensure that the code in this helper is used in the few places it should be and will make this change significantly bigger for a pretty small gain. |
russellhancox
approved these changes
Jun 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a helper function to format the Signing IDs in Santa and to ensure they're always handled and formatted the same way.
It's marked draft until we're sure that it's used everywhere it should be and that folks are happy with it.