This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Testing: update E2E to use JIT runners #1335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellhancox
suggested changes
May 1, 2024
pmarkowsky
reviewed
May 1, 2024
Contributor
pmarkowsky
left a comment
There was a problem hiding this comment.
Overall looks good.
Some nits.
russellhancox
approved these changes
May 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the E2E test pipeline to register ephemeral just in time runners via the GitHub API and dynamically inject the runner token into the VM. This means VM images no longer have any keys inside of them, and they won't expire if unused.
This also splits the start_vm script into 2, one to update the image (if applicable) and the other to register a runner and start the VM.