This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Entitlements logging config options #1233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kallsyms
reviewed
Nov 10, 2023
pmarkowsky
suggested changes
Nov 13, 2023
Contributor
pmarkowsky
left a comment
There was a problem hiding this comment.
Only thing is renaming the mutex. Otherwise this seems fine.
Please treat the other suggestions as nits.
pmarkowsky
approved these changes
Nov 13, 2023
Contributor
pmarkowsky
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for making that change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two configuration options supporting entitlement logging:
EntitlementsTeamIDFilter- Filter out entitlements from binaries from configured organizationsEntitlementsPrefixFilter- Filter out specific entitlement prefixes