Skip to content

Add tag_regex for dynamic version #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmr merged 2 commits into from
Aug 22, 2025
Merged

Add tag_regex for dynamic version #451

jmr merged 2 commits into from
Aug 22, 2025

Conversation

@b4rdos
Copy link
Contributor

@b4rdos b4rdos commented Aug 21, 2025 

> python -m build --wheel "-C--global-option=build_ext" "-C--global-option=-DBUILD_TESTS=OFF;Python3_FIND_VIRTUALENV=ONLY"
...
removing build/bdist.macosx-15.0-arm64/wheel
Successfully built s2geometry-0.0.0-cp312-cp312-macosx_15_0_arm64.whl
  • After fix
> python -m build --wheel "-C--global-option=build_ext" "-C--global-option=-DBUILD_TESTS=OFF;Python3_FIND_VIRTUALENV=ONLY"
...
removing build/bdist.macosx-15.0-arm64/wheel
Successfully built s2geometry-0.12.1.dev28+g672409037-cp312-cp312-macosx_15_0_arm64.whl

@jmr
Copy link
Member

jmr commented Aug 21, 2025

Explicitly adds the default tag regex defined in setuptools_scm

Why is the default not actually the default?

@jmr
Copy link
Member

jmr commented Aug 21, 2025

@selimnairb @zacharyburnett

@selimnairb
Copy link
Contributor

selimnairb commented Aug 21, 2025

Looks good to me!

@jmr jmr merged commit d048896 into google:master Aug 22, 2025
10 checks passed
@jmr
Copy link
Member

jmr commented Aug 22, 2025

Thanks!

@jmr jmr mentioned this pull request Aug 22, 2025
Closed
@BrewTestBot BrewTestBot mentioned this pull request Dec 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@b4rdos @jmr @selimnairb