Update s2builder.h comments #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kIntersectionSnapRadius is not defined anywhere. The comments from s2edge_crossings.h for kIntersectionMergeRadius indicate this is what it meant. // This value can be used as the S2Builder snap_radius() to ensure that edges // that have been displaced by up to kIntersectionError are merged back // together again. For example this can happen when geometry is intersected // with a set of tiles and then unioned. It is equal to twice the // intersection error because input edges might have been displaced in // opposite directions. constexpr S1Angle kIntersectionMergeRadius = 2 * kIntersectionError;
kIntersectionSnapRadius is not defined anywhere. The comments from s2edge_crossings.h for kIntersectionMergeRadius indicate this is what it meant. // This value can be used as the S2Builder snap_radius() to ensure that edges // that have been displaced by up to kIntersectionError are merged back // together again. For example this can happen when geometry is intersected // with a set of tiles and then unioned. It is equal to twice the // intersection error because input edges might have been displaced in // opposite directions. constexpr S1Angle kIntersectionMergeRadius = 2 * kIntersectionError;
jmr
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kIntersectionSnapRadius is not defined anywhere. The comments from s2edge_crossings.h for kIntersectionMergeRadius indicate this is what it meant.
// This value can be used as the S2Builder snap_radius() to ensure that edges // that have been displaced by up to kIntersectionError are merged back // together again. For example this can happen when geometry is intersected // with a set of tiles and then unioned. It is equal to twice the // intersection error because input edges might have been displaced in // opposite directions.
constexpr S1Angle kIntersectionMergeRadius = 2 * kIntersectionError;