Skip to content

Conversation

@benbovy
Copy link
Contributor

@benbovy benbovy commented Aug 15, 2024

This will help handling s2 versions in downstream cmake projects.

COMPATIBILITY SameMinorVersion seems safer than SameMajorVersion or AnyNewerVersion (cf. some changes like S2ShapeIndex::CellRelation => S2CellRelation from v0.10 to v0.11).

@google-cla
Copy link

google-cla bot commented Aug 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jmr jmr merged commit a2b2da7 into google:master Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants