Skip to content

Remove flags (s2a_timeout, s2a_enable_appengine_dialer) #107

@howardjohn

Description

@howardjohn

These flags are registered by any binary that imports this library as they are registered in init(). This in turn means they should up in our binaries. This is unexpected for users.

While I couldn't find anything official recommending not to do that, looking at our entire dependency tree, which is quite large, this is the only library that does this. This leads me to believe that using flags in libraries (as opposed to binaries) is not a very established pattern in the ecosystem.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions