Skip to content

Detect invalid unicode class specification #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sjamesr merged 1 commit into from
Oct 23, 2018
Merged

Detect invalid unicode class specification #74

sjamesr merged 1 commit into from
Oct 23, 2018

Conversation

@sjamesr
Copy link
Contributor

@sjamesr sjamesr commented Sep 26, 2018

Previously, the parser would unconditionally attempt to read the unicode
class spec after a \p or \P, even if the pattern is truncated and
invalid.

Fixes issue #72.

@coveralls
Copy link

coveralls commented Sep 26, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 225

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 93.966%
Files with Coverage Reduction New Missed Lines %
/home/travis/build/google/re2j/java/com/google/re2j/Parser.java 2 95.38%
Totals Coverage Status
Change from base Build 222: 0.07%
Covered Lines: 2943
Relevant Lines: 3132
💛 - Coveralls

@sjamesr
Detect invalid unicode class specification
710be16 
Previously, the parser would unconditionally attempt to read the unicode
class spec after a \p or \P, even if the pattern is truncated and
invalid.

Fixes issue google#72.
@sjamesr sjamesr merged commit f6c10c7 into google:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sjamesr @coveralls @googlebot