Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/re2
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: be0e1305d264
Choose a base ref
...
head repository: google/re2
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5bd613749fd5
Choose a head ref
  • 4 commits
  • 4 files changed
  • 2 contributors

Commits on Aug 26, 2019

  1. Simplify the plumbing for re2.pc.

    Change-Id: I6503b73978c9b2f4693422b62a74d4e1c75409c7
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/44491
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    960cdcc View commit details
    Browse the repository at this point in the history
  2. Improvements in install target generated by CMake

    There are two changes in this patch but they are related because they
    both improve install target generated by CMake.
    
    1) GNUInstallDirs is now used to determine name of the folders where
    libraries and headers are installed. On RedHat based Linux
    distributions, usual folder for x86-64 libraries is lib64 and not just
    simply lib. GNUInstallDirs takes care of deciding which name to use.
    
    2) Pkgconfig file was not installed when CMake was used. Adding pc file
    to the installation process of CMake install target allows package
    maintainers to easily provide packages which work both with pkgconfig
    and CMake.
    
    Fixes #215.
    
    Change-Id: Icc9636039e5456df78323b7ae1b89e0d27be7fbf
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/43990
    Reviewed-by: Paul Wankadia <junyer@google.com>
    metthal authored and junyer committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    7a10064 View commit details
    Browse the repository at this point in the history
  3. Adjust a thread annotation.

    Change-Id: Ib7867190116fbc65d404804c4f14392f599d8bd3
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/44510
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    9d26344 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2019

  1. Partial revert of commit 7a10064.

    If CMake doesn't support building libre2.a and libre2.so together and
    installing them together, then it isn't suitable for use in packaging
    and so installing re2.pc isn't needed.
    
    Fixes #215.
    
    Change-Id: I83e329f39da97ed6c4184564bd4ac85709800213
    Reviewed-on: https://code-review.googlesource.com/c/re2/+/44630
    Reviewed-by: Paul Wankadia <junyer@google.com>
    junyer committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    5bd6137 View commit details
    Browse the repository at this point in the history
Loading