Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/re2
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 848dfb7e1d7b
Choose a base ref
...
head repository: google/re2
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e356bd3f80e0
Choose a head ref
  • 6 commits
  • 4 files changed
  • 1 contributor

Commits on Jul 4, 2019

  1. Stop SimplifyStringSet() from finding "" in everything. 

    Change-Id: I98313d86a5a4653b449bf943ea0c57844dfcc130
Reviewed-on: https://code-review.googlesource.com/c/re2/+/42510
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    7faea1d View commit details
    Browse the repository at this point in the history

  2. Fix a typographical error. 

    Change-Id: I637c50a52d1e4b54000c6f368d5a89f9468a2ac7
Reviewed-on: https://code-review.googlesource.com/c/re2/+/42512
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    dab5c0f View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2019

  1. Fix SimplifyStringSet() properly. Ensure test coverage. 

    Change-Id: Ifca0d469c2c0858afdf899381bb27563774cc6a8
Reviewed-on: https://code-review.googlesource.com/c/re2/+/42514
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    6e70e9e View commit details
    Browse the repository at this point in the history

  2. Don't let Prefilter::OrStrings() return NULL. 

    Change-Id: I13185f194e80cf5cdcd4e562f17fd86a57a67fbb
Reviewed-on: https://code-review.googlesource.com/c/re2/+/42516
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    a7d27d6 View commit details
    Browse the repository at this point in the history

  3. Fix SimplifyStringSet() for really reals. And the test. 

    Change-Id: I4c211f8f4eea0a5b2afcbb85319a8467b7f29398
Reviewed-on: https://code-review.googlesource.com/c/re2/+/42518
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    9d6788a View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2019

  1. Make RE2::Set canonicalize DFA states. 

    Change-Id: Ib397b8fb7af447e62fbe8a30f75e3da8322e44a6
Reviewed-on: https://code-review.googlesource.com/c/re2/+/42570
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    e356bd3 View commit details
    Browse the repository at this point in the history
Loading