Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/re2
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 67bce690decd
Choose a base ref
...
head repository: google/re2
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: be0e1305d264
Choose a head ref
  • 15 commits
  • 20 files changed
  • 1 contributor

Commits on Aug 15, 2019

  1. Upgrade Travis CI from Trusty to Xenial. 

    Change-Id: I8d49b93887640310e37c89fbaa643e308e187118
Reviewed-on: https://code-review.googlesource.com/c/re2/+/44150
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    01e9934 View commit details
    Browse the repository at this point in the history

  2. Configure CMake to require version 3.5.1, which is what Xenial has. 

    Change-Id: Iffde5091b8e9a567e61d7638c70779d7f4b6a9f3
Reviewed-on: https://code-review.googlesource.com/c/re2/+/44151
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    70b8d63 View commit details
    Browse the repository at this point in the history

  3. Configure Kokoro to run CMake builds on Ubuntu. 

    Change-Id: I616783521bbfc21449ee3ea1a72a23a4ae27bad5
Reviewed-on: https://code-review.googlesource.com/c/re2/+/44152
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    fe859a2 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2019

  1. Switch to Starlark for C++ rules. 

    Change-Id: I3c8e52973506f5dcc96f98460f7d0b3e1263f381
Reviewed-on: https://code-review.googlesource.com/c/re2/+/44211
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    d07b6d7 View commit details
    Browse the repository at this point in the history

  2. Upgrade Bazel before trying to build with it. 

    Change-Id: I412f23a7e4e933642d6fecdededca4aea0190c37
Reviewed-on: https://code-review.googlesource.com/c/re2/+/44214
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    c19f2d6 View commit details
    Browse the repository at this point in the history

  3. Try to upgrade Bazel harder on Windows. 

    Change-Id: I22ad66dc3ebd4f4bf95605e114d07bea3f67d6eb
Reviewed-on: https://code-review.googlesource.com/c/re2/+/44216
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    ea36c39 View commit details
    Browse the repository at this point in the history

  4. Argh. Try a different flag. 

    Change-Id: Ia0f1f6aaeae035d27caa479c68e4293855dfeb9e
Reviewed-on: https://code-review.googlesource.com/c/re2/+/44218
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    4d5eecd View commit details
    Browse the repository at this point in the history

  5. Attempt to address VCVARSALL.BAT breakage. Sigh. 

    Change-Id: Ifc9853714e1fb73b8bed30d0e9dd620446319197
Reviewed-on: https://code-review.googlesource.com/c/re2/+/44220
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    3b481d0 View commit details
    Browse the repository at this point in the history

  6. Attempt to avoid VCVARSALL.BAT breakage entirely. 

    Change-Id: I9b4b4e64f463e5b55fbc9c22e12b7d3e7fecc172
Reviewed-on: https://code-review.googlesource.com/c/re2/+/44222
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    13d5385 View commit details
    Browse the repository at this point in the history

  7. Comment on why we pin to Visual Studio 2015. 

    Change-Id: Iaa0dd108c3a446b64f0a0effdcae97d521226792
Reviewed-on: https://code-review.googlesource.com/c/re2/+/44224
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    96c3543 View commit details
    Browse the repository at this point in the history

  8. Ensure that CMake is in the path on Windows. 

    Change-Id: Idc54e26dac243c0b354ec55759b8f87ed83af083
Reviewed-on: https://code-review.googlesource.com/c/re2/+/44226
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    6b1d89c View commit details
    Browse the repository at this point in the history

  9. Try under 'C:\Program Files (x86)' instead. Sigh. 

    Change-Id: I553c4bc94c0e38b7d03e745e22b88e7257ccde42
Reviewed-on: https://code-review.googlesource.com/c/re2/+/44227
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    ee2e1db View commit details
    Browse the repository at this point in the history

  10. No, it was right before. Try the /cygdrive form. 

    Change-Id: Icaee640f0e422890ee705b0cec9ab00ea41985ec
Reviewed-on: https://code-review.googlesource.com/c/re2/+/44228
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Aug 18, 2019
    2 Configuration menu
    Copy the full SHA
    9d34a04 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2019

  1. Don't assume that iterators are just pointers. 

    That is the case for re2::StringPiece and absl::string_view
and happens to be the case for std::string_view in libstdc++
and libc++, but std::string_view in MSVC has iterators that
aren't just pointers.

Fixes #214.

Change-Id: I99542a1b53f138228a54f3845df140465a71980d
Reviewed-on: https://code-review.googlesource.com/c/re2/+/44230
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    59a5c74 View commit details
    Browse the repository at this point in the history

  2. Add Clang 9 to the Travis CI matrix. 

    Change-Id: I82c534335a27a68df2e3459495122cdeb7dedf6a
Reviewed-on: https://code-review.googlesource.com/c/re2/+/44232
Reviewed-by: Paul Wankadia <junyer@google.com>
    @junyer
    junyer committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    be0e130 View commit details
    Browse the repository at this point in the history
Loading