Skip to content

CI: Also run plugin tests on Chrome, with dart2js and dart2wasm#1031

Merged
osa1 merged 12 commits into
google:masterfrom
osa1:browser_tests
Jul 28, 2025
Merged

CI: Also run plugin tests on Chrome, with dart2js and dart2wasm#1031
osa1 merged 12 commits into
google:masterfrom
osa1:browser_tests

Conversation

@osa1

@osa1 osa1 commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@osa1 osa1 requested a review from devoncarew July 24, 2025 14:53
This was referenced Jul 24, 2025
@osa1

osa1 commented Jul 24, 2025

Copy link
Copy Markdown
Contributor Author

We need to skip golden tests when running tests in browsers as we can't use the file system API in the browser. I'll update.

Comment thread protoc_plugin/mono_pkg.yaml Outdated
@osa1

osa1 commented Jul 25, 2025

Copy link
Copy Markdown
Contributor Author

This reveals an existing issue in the library or the tests. I'm working on fixing it.

@osa1 osa1 changed the title CI: Also run tests on Chrome, with dart2js and dart2wasm CI: Also run plugin tests on Chrome, with dart2js and dart2wasm Jul 28, 2025
@osa1 osa1 requested a review from devoncarew July 28, 2025 09:04

@devoncarew devoncarew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@osa1 osa1 merged commit f7f65d4 into google:master Jul 28, 2025
5 checks passed
@osa1 osa1 deleted the browser_tests branch July 28, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants