Make PbFieldType members public#1027
Merged
Merged
Conversation
In preparation for adding conditional imports to be able to use different encoding/decoding implementation based on the platform, this PR creates an "internal" library and exports some of the important types for encoding/decoding like `FieldInfo`, `PbFieldType` (renamed as `PbFieldTypeInternal`). This syncs some of cl/613649886.
Merged
This reverts commit 32911d8.
devoncarew
approved these changes
Jul 18, 2025
devoncarew
left a comment
Contributor
There was a problem hiding this comment.
lgtm
My main comment is the PbFieldType => PbFieldTypeInternal rename from the precursor PR.
devoncarew
approved these changes
Jul 22, 2025
devoncarew
left a comment
Contributor
There was a problem hiding this comment.
lgtm. I have a slight preference for landing #1026 and rebasing this PR against master before landing, but don't think the mechanics are part of the review - whichever you think is best.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1026.
This is the second part of the PRs that sync internal JSON decoding chages.
To be able to have JSON decoders as libraries that are conditionally imported
based on the compilation target, this makes
PbFieldTypemembers public.