Skip modules that have no match. #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A package might contain modules that are only compatible with some configurations. The motivating example of this is where a package contains a shared library that uses c++_shared, but the user is using c++_static. In this case, the one incompatible module shouldn't preclude the user from using other modules in the package. I don't really like the implementation here. The decision of whether incompatible modules should be skipped or cause an error should not be made by each build system plugin, but it'll take some rearranging of the build system interface API to make that the CLI's responsibility. I'm making this quick fix for our in-tree build systems for now, and will the organization when we have more changes that justify a major release.
enh-google
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A package might contain modules that are only compatible with some
configurations. The motivating example of this is where a package
contains a shared library that uses c++_shared, but the user is using
c++_static. In this case, the one incompatible module shouldn't
preclude the user from using other modules in the package.
I don't really like the implementation here. The decision of whether
incompatible modules should be skipped or cause an error should not be
made by each build system plugin, but it'll take some rearranging of
the build system interface API to make that the CLI's responsibility.
I'm making this quick fix for our in-tree build systems for now, and
will the organization when we have more changes that justify a major
release.