Add note for implicit API level in duplicates. #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc887d8 to
4cafd79
Compare
The pull-up done for the API level prior to the first supported API level for the ABI is done silently, so users that aren't aware of this behavior are likely to be confused by the apparent non-duplicates in their duplicate lists. Add a note to the error message to make it clear. When we eventually break the schema we should just explicitly disallow API levels that were never supported for the given ABI. Fixes google#100
4cafd79 to
8ba84c7
Compare
enh-google
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull-up done for the API level prior to the first supported API
level for the ABI is done silently, so users that aren't aware of this
behavior are likely to be confused by the apparent non-duplicates in
their duplicate lists. Add a note to the error message to make it
clear.
When we eventually break the schema we should just explicitly disallow
API levels that were never supported for the given ABI.
Fixes #100