Skip to content

ci: Disable staticcheck on tip-of-tree compiler.#664

Merged
aalexand merged 2 commits intogoogle:masterfrom
s-kanev:ci_staticcheck
Nov 2, 2021
Merged

ci: Disable staticcheck on tip-of-tree compiler.#664
aalexand merged 2 commits intogoogle:masterfrom
s-kanev:ci_staticcheck

Conversation

@s-kanev
Copy link
Copy Markdown
Contributor

@s-kanev s-kanev commented Nov 2, 2021 •
edited
Loading

staticcheck only supports the latest 2 copmiler releases, not unreleased tip-of-tree versions.

Fixes #662.

@s-kanev
ci: Disable staticcheck on tip-of-tree compiler.
101081c 
staticcheck only supports the latest 2 copmiler releases.

Fixes google#662.
@google-cla google-cla bot added the cla: yes label Nov 2, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 2, 2021 •
edited
Loading

Codecov Report

Merging #664 (86d63d3) into master (947d60d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #664   +/-   ##
=======================================
  Coverage   68.18%   68.18%           
=======================================
  Files          41       41           
  Lines        7386     7386           
=======================================
  Hits         5036     5036           
  Misses       1909     1909           
  Partials      441      441

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 947d60d...86d63d3. Read the comment docs.

@aalexand
Copy link
Copy Markdown
Collaborator

aalexand commented Nov 2, 2021

The PR description is a bit confusing:

The title says "disable staticcheck on tip" but the description says "staticcheck only support latest 2 compiler versions" - but the tip is the most latest version I would think...

@s-kanev
Copy link
Copy Markdown
Contributor Author

s-kanev commented Nov 2, 2021

The PR description is a bit confusing:

The title says "disable staticcheck on tip" but the description says "staticcheck only support latest 2 compiler versions" - but the tip is the most latest version I would think...

Updated to clarify -- it did say "latest 2 compiler releases", and tip isn't a formal release.

@s-kanev
Copy link
Copy Markdown
Contributor Author

s-kanev commented Nov 2, 2021

@aalexand can you merge? And/or add me as a project contributor so we can skip an extra roundtrip in the future.

@aalexand aalexand merged commit 6c32895 into google:master Nov 2, 2021
@s-kanev s-kanev deleted the ci_staticcheck branch November 8, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aalexand aalexand aalexand approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI failing on staticcheck version

3 participants

@s-kanev @codecov-commenter @aalexand