Prefer newer lazy task configuration gradle api for merge resources#62
Prefer newer lazy task configuration gradle api for merge resources#62davidmotson merged 2 commits intogoogle:masterfrom jzbrooks:gradle-warning-fix
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
Added a new cla for a work email address |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
|
|
@colinrtwhite As requested, the google services plugin has been fixed as well. |
|
Thanks! Unfortunately, I don't have permissions to merge or I would. I believe @davidmotson and @zhiqiao have access. |
Zeuskartik
left a comment
There was a problem hiding this comment.
Need to fix this for google play services plugin as well, kindly do the needful.
It's fixed in the PR already. It just needs to be merged and shipped. |
|
I've forked the Google Play Services Plugin here and merged @jzbrooks's PR. To use it add JitPack to your list of repositories: buildscript {
repositories {
maven { url 'https://jitpack.io' }
}
}And replace the plugin in your list of dependencies: buildscript {
dependencies {
// Replace "classpath 'com.google.gms:google-services:4.3.0'" with:
classpath 'com.github.colinrtwhite:google-services:9da6686'
}
} |
|
@zhiqiao would it be possible to get this merged and in a release soon? Is there someone I could loop into this review that might be more available for review if you aren't able? |
|
Hi, thank you very much for your work on this. I'll merge it in and release it within the next month. |
|
Thanks! |
|
Any news about an upcoming release that includes this fix? Thanks. |
I am facing following issue :
|
Addresses #57