Merged
Conversation
josieang
approved these changes
Dec 6, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
=======================================
Coverage 78.86% 78.86%
=======================================
Files 84 84
Lines 5943 5943
=======================================
Hits 4687 4687
Misses 1054 1054
Partials 202 202 ☔ View full report in Codecov by Sentry. |
michaelkedar
approved these changes
Dec 6, 2023
Member
michaelkedar
left a comment
There was a problem hiding this comment.
Latest experimental package requires golang.org/x/tools v0.16.0, which removed a module required by govulncheck.
Should probably change govulncheck to not depend on the removed module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current go mod file does not compile #688 (I am actually unsure how it managed to get merged in the first place, maybe caused by our CI being 1.20 rather than 1.22).
Latest experimental package requires golang.org/x/tools v0.16.0, which removed a module required by govulncheck.