Skip to content

test(fix): add cases for --offline-vulnerabilities and unsupported flag values#2244

Merged
another-rex merged 2 commits intogoogle:mainfrom
ackama:test/add-case
Sep 23, 2025
Merged

test(fix): add cases for --offline-vulnerabilities and unsupported flag values#2244
another-rex merged 2 commits intogoogle:mainfrom
ackama:test/add-case

Conversation

@G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Sep 22, 2025

I realized we were missing these while working on #2241

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.68%. Comparing base (76887ec) to head (213125f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2244      +/-   ##
==========================================
+ Coverage   66.53%   66.68%   +0.15%     
==========================================
  Files         169      169              
  Lines       16379    16379              
==========================================
+ Hits        10897    10923      +26     
+ Misses       4713     4688      -25     
+ Partials      769      768       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@G-Rath G-Rath changed the title test(fix): add cases for --offline-vulnerabilities test(fix): add cases for --offline-vulnerabilities and unsupported flag values Sep 22, 2025
@G-Rath
Copy link
Collaborator Author

G-Rath commented Sep 22, 2025

@michaelkedar I don't suppose you've got the package.json for cmd/osv-scanner/fix/testdata/in-place-npm? I'd like to add a case for covering preferring the directory of the manifest over the lockfile, and also interested in seeing if it might be possible to make the lockfile a bit smaller (though I'm less committed to that 😅)

@another-rex another-rex merged commit b9bc640 into google:main Sep 23, 2025
31 of 33 checks passed
@another-rex another-rex deleted the test/add-case branch September 23, 2025 04:38
@michaelkedar
Copy link
Member

@michaelkedar I don't suppose you've got the package.json for cmd/osv-scanner/fix/testdata/in-place-npm? I'd like to add a case for covering preferring the directory of the manifest over the lockfile, and also interested in seeing if it might be possible to make the lockfile a bit smaller (though I'm less committed to that 😅)

It looks like it was cmd/osv-scanner/fix/testdata/relax-npm/package.json, except the version of npm-registry-client was "^6.2.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants