Skip to content

fix(output): change links to go to vuln page instead of list page#2068

Merged
jess-lowe merged 2 commits intogoogle:mainfrom
jess-lowe:fix/link-to-vuln
Jul 14, 2025
Merged

fix(output): change links to go to vuln page instead of list page#2068
jess-lowe merged 2 commits intogoogle:mainfrom
jess-lowe:fix/link-to-vuln

Conversation

@jess-lowe
Copy link
Copy Markdown
Contributor

Closes #2066

@jess-lowe jess-lowe requested review from G-Rath and another-rex July 14, 2025 03:53
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.05%. Comparing base (de97ce5) to head (0890c75).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2068   +/-   ##
=======================================
  Coverage   66.05%   66.05%           
=======================================
  Files         172      172           
  Lines       16192    16192           
=======================================
  Hits        10696    10696           
  Misses       4846     4846           
  Partials      650      650           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, though I just realized we're doing https://osv.dev/<id> for other outputs like table which gets redirected to /vuln - is there a reason why we weren't doing that here before and also now?

(we do want to keep using it in places like the table output because its shorter, which isn't as important for these outputs but it would still be a little less data and consistent)

@jess-lowe
Copy link
Copy Markdown
Contributor Author

looks good, though I just realized we're doing https://osv.dev/<id> for other outputs like table which gets redirected to /vuln - is there a reason why we weren't doing that here before and also now?

(we do want to keep using it in places like the table output because its shorter, which isn't as important for these outputs but it would still be a little less data and consistent)

Not sure why, but updated to use the shorter vers regardless.

@jess-lowe jess-lowe merged commit 3eceb8a into google:main Jul 14, 2025
16 checks passed
@jess-lowe jess-lowe deleted the fix/link-to-vuln branch July 14, 2025 05:12
@another-rex
Copy link
Copy Markdown
Collaborator

We were not doing that before here because before the CVE didn't exist in OSV, and we didn't have the redirect to the search page, and just 404s. Now we have the redirect we can now point directly to the short link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Point to vuln record not list view in scanner output

4 participants