fix(output): change links to go to vuln page instead of list page#2068
fix(output): change links to go to vuln page instead of list page#2068jess-lowe merged 2 commits intogoogle:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2068 +/- ##
=======================================
Coverage 66.05% 66.05%
=======================================
Files 172 172
Lines 16192 16192
=======================================
Hits 10696 10696
Misses 4846 4846
Partials 650 650 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
G-Rath
left a comment
There was a problem hiding this comment.
looks good, though I just realized we're doing https://osv.dev/<id> for other outputs like table which gets redirected to /vuln - is there a reason why we weren't doing that here before and also now?
(we do want to keep using it in places like the table output because its shorter, which isn't as important for these outputs but it would still be a little less data and consistent)
Not sure why, but updated to use the shorter vers regardless. |
|
We were not doing that before here because before the CVE didn't exist in OSV, and we didn't have the redirect to the search page, and just 404s. Now we have the redirect we can now point directly to the short link. |
Closes #2066