fix: govulncheck calls on C code#1228
Merged
another-rex merged 6 commits intogoogle:mainfrom Sep 6, 2024
Merged
Conversation
Collaborator
Author
|
Actually, a better solution would be to set CGO_ENABLED=0 just before calling govulncheck itself in the code. I'll make that change. |
oliverchang
approved these changes
Sep 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1228 +/- ##
==========================================
- Coverage 67.65% 67.65% -0.01%
==========================================
Files 174 174
Lines 16719 16721 +2
==========================================
+ Hits 11312 11313 +1
- Misses 4776 4777 +1
Partials 631 631 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CGO and govulncheck not working well together. govulncheck does not work on C code anyway, so disabling CGO doesn't change any capabilities.
Fixes #1220