feat(guided remediation): add --upgrade-config flag#1191
feat(guided remediation): add --upgrade-config flag#1191michaelkedar merged 11 commits intogoogle:mainfrom
--upgrade-config flag#1191Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1191 +/- ##
==========================================
+ Coverage 65.66% 65.79% +0.13%
==========================================
Files 165 167 +2
Lines 13983 14064 +81
==========================================
+ Hits 9182 9254 +72
- Misses 4298 4304 +6
- Partials 503 506 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
--upgrade-config flag--upgrade-config flag
docs/guided-remediation.md
Outdated
| - `patch` allows for updates `>=1.2.3, <1.3.0` | ||
| - `none` disallows any updates | ||
|
|
||
| If `package-name:` is omitted, `level` is applied to all packages. Default is `--upgrade-config=major`. |
There was a problem hiding this comment.
Can we add some detail to describe precedence?
i.e. our behavior is to take the most specific setting right? if a specific package is specified in a config, that takes precedence over a global config.
There was a problem hiding this comment.
+1 - it is not clear to me whether the specific settings overwrite the global ones until I see the example usage.
There was a problem hiding this comment.
Added some explanation w.r.t precedence here
docs/guided-remediation.md
Outdated
| - `patch` allows for updates `>=1.2.3, <1.3.0` | ||
| - `none` disallows any updates | ||
|
|
||
| If `package-name:` is omitted, `level` is applied to all packages. Default is `--upgrade-config=major`. |
There was a problem hiding this comment.
+1 - it is not clear to me whether the specific settings overwrite the global ones until I see the example usage.
closes #1177
--upgrade-configflag for configuring allowed upgrades on a per-package basis.--disallow-major-upgradesand--disallow-package-upgradesflags.