Reflect Go 1.21.12 change more broadly#1133
Merged
andrewpollock merged 2 commits intogoogle:mainfrom Jul 22, 2024
Merged
Conversation
Replicate google#1109 more like google#1030 to avoid Renovate failures like google#1120 (comment) The Docker files are already at 1.22.5, not sure if we want to update to this globally?
This is already at a version higher than 1.21.12
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1133 +/- ##
==========================================
- Coverage 65.24% 65.21% -0.03%
==========================================
Files 162 162
Lines 13424 13424
==========================================
- Hits 8758 8755 -3
- Misses 4183 4185 +2
- Partials 483 484 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
another-rex
approved these changes
Jul 22, 2024
Collaborator
|
We probably should update to 1.22.5 in most places (but still keep the library compatible with 1.21.12), #1123 (comment) is also worth looking at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replicate #1109 more like #1030 to avoid Renovate failures like #1120 (comment)
The Docker files are already at 1.22.5, not sure if we want to update to this globally?