Skip to content

fix: restore custom styling to table format#1094

Merged
another-rex merged 1 commit intogoogle:mainfrom
ackama:refactor/change-order
Jul 9, 2024
Merged

fix: restore custom styling to table format#1094
another-rex merged 1 commit intogoogle:mainfrom
ackama:refactor/change-order

Conversation

@G-Rath
Copy link
Copy Markdown
Collaborator

@G-Rath G-Rath commented Jul 2, 2024

I mistakenly changed the order that styles are applied in #1087 for the table formatter so our custom styles were immediately overridden when the rounded style was applied

@G-Rath G-Rath requested review from another-rex, cuixq and hogo6002 July 2, 2024 23:30
@G-Rath G-Rath force-pushed the refactor/change-order branch from d461c9a to 1c07b6a Compare July 9, 2024 00:26
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 9, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.91%. Comparing base (fcc7afb) to head (1c07b6a).
⚠️ Report is 1106 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1094      +/-   ##
==========================================
- Coverage   65.94%   65.91%   -0.03%     
==========================================
  Files         159      159              
  Lines       12758    12758              
==========================================
- Hits         8413     8410       -3     
- Misses       3885     3887       +2     
- Partials      460      461       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@another-rex another-rex merged commit 1460154 into google:main Jul 9, 2024
@G-Rath G-Rath deleted the refactor/change-order branch July 9, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants