Skip to content

abort botan tests when an assertion is not met#8320

Open
lz101010 wants to merge 5 commits intogoogle:masterfrom
lz101010:patch-1
Open

abort botan tests when an assertion is not met#8320
lz101010 wants to merge 5 commits intogoogle:masterfrom
lz101010:patch-1

Conversation

@lz101010
Copy link
Copy Markdown

@lz101010 lz101010 commented Aug 23, 2022

@google-cla
Copy link
Copy Markdown

google-cla bot commented Aug 23, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jonathanmetzman
Copy link
Copy Markdown
Contributor

@randombit Do you approve?

@randombit
Copy link
Copy Markdown
Contributor

@jonathanmetzman Sorry about delay, yes looks good to me

Copy link
Copy Markdown
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathanmetzman jonathanmetzman enabled auto-merge (squash) October 20, 2022 18:52
@lz101010
Copy link
Copy Markdown
Author

Sorry about requesting approvals again, it seems that in the meantime there was at least one other PR which was merged and the workflow setup now considers my branch stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants