Skip to content

projects: add uint256#6497

Merged
jonathanmetzman merged 4 commits intogoogle:masterfrom
holiman:uint256
Aug 21, 2022
Merged

projects: add uint256#6497
jonathanmetzman merged 4 commits intogoogle:masterfrom
holiman:uint256

Conversation

@holiman
Copy link
Copy Markdown
Contributor

@holiman holiman commented Sep 21, 2021

This PR adds https://github.com/holiman/uint256 to oss-fuzz.

uint256 is a 256-bit math library in golang, and is used primarily within the Ethereum ecosystem, by projects such as go-ethereum and erigon

@holiman
Copy link
Copy Markdown
Contributor Author

holiman commented Sep 21, 2021 •
edited
Loading

cc @chfast is that the non-aliased version of your email address?

@chfast
Copy link
Copy Markdown

chfast commented Sep 21, 2021

cc @chfast is that the non-aliased version of your email address?

Yes.

@holiman holiman mentioned this pull request Sep 21, 2021
Merged
@holiman
Copy link
Copy Markdown
Contributor Author

holiman commented Oct 27, 2021

Fixed the issues, tested the integration locally, fuzzer worked fine. PTAL

@holiman
Copy link
Copy Markdown
Contributor Author

holiman commented Nov 29, 2021

A gentle ping on this?

@holiman
Copy link
Copy Markdown
Contributor Author

holiman commented Feb 22, 2022

Friendly ping on this. The uint256 library is used in several blockchain projects based on go-ethereum. Is there anything in particular preventing this from being approved?

@holiman holiman mentioned this pull request May 10, 2022
Closed
@jonathanmetzman
Copy link
Copy Markdown
Contributor

jonathanmetzman commented Aug 17, 2022

Are you still interested in this integration? If yes I'll ask the panel to consider. Otherwise maybe you should consider clusterfuzzlite

@holiman
Copy link
Copy Markdown
Contributor Author

holiman commented Aug 18, 2022

Are you still interested in this integration?

Yes, I very much am

@jonathanmetzman
Copy link
Copy Markdown
Contributor

jonathanmetzman commented Aug 18, 2022

Are you still interested in this integration?

Yes, I very much am

Are there other users? I guess we sort of consider ethereum critical but if there are non-blockchain users we are more likely to accept.

@holiman
Copy link
Copy Markdown
Contributor Author

holiman commented Aug 19, 2022

Not that I am aware of, no

jonathanmetzman
jonathanmetzman approved these changes Aug 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanmetzman jonathanmetzman merged commit 7ce3c5f into google:master Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanmetzman jonathanmetzman jonathanmetzman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@holiman @chfast @jonathanmetzman