Closed
Conversation
Contributor
Author
|
Hmm, on second thought, just moving the controls up to the container node has some a11y implications (and probably more). I think instead I'll make a canvas container that the two canvases can live in and put all the DOM stuff on it instead. |
Merged
Contributor
Author
|
I think we can close this in favor of #995. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #845
My method here involves placing the renderer's canvas element into the shadow root when there is only one registered scene, thus bypassing the slow drawImage call. For multiple scenes on a page, it falls back to the old behavior. Unfortunately this also meant removing OffscreenCanvas, but this is currently doing nothing for us as it hasn't been hooked up to an ImageBitmapRenderingContext yet. I'm hoping this approach can be extended to support OffscreenCanvas in the future, but it's hard to tell from the limited API documentation so far.