Conversation
jsantell
approved these changes
Feb 14, 2019
Contributor
jsantell
left a comment
There was a problem hiding this comment.
Small text nit, looks great! 👍 thanks for taking care of this
| experimental-pmrem | ||
| style="width: 768px; height: 768px;"> | ||
| </model-viewer> | ||
| <p>This model demonstrates the alpha blending behavior of a semi-transparent "container" object surrounding several opaque objects.</p> |
Contributor
There was a problem hiding this comment.
Nit: this refers to the other opacity test
66623b7 to
6c220e8
Compare
Contributor
Author
|
It turned out that I had messed up the IBL orientation when producing the Filament golden. This has been addressed in #351 and I have updated the golden in this change. Here is a more up to date comparison:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change proposes a final addition to #338 : a fidelity test to help us track changes and potential regressions related to HDR and PMREM. Some details:
experimental-pmrem<model-viewer>when the environment map changes<model-viewer><model-viewer>was added so that we can track changes compared to ourselvesgltf_renderernow matches the orientation of the skybox in<model-viewer><model-viewer><-> Filament