Conversation
| ], | ||
| }; | ||
|
|
||
| const onwarn = (warning, warn) => { |
There was a problem hiding this comment.
This was new to me! https://rollupjs.org/guide/en#onwarn
| "dependencies": { | ||
| "@polymer/lit-element": "^0.6.2", | ||
| "three": "^0.94.0" | ||
| "three": "^0.98.0" |
| 'lib/third_party/three/GLTFLoader.js': [ | ||
| 'DDSLoader', | ||
| 'BufferGeometryUtils', | ||
| 'DRACOLoader', |
There was a problem hiding this comment.
Will we eventually include this for draco support?
There was a problem hiding this comment.
Yeah, if we want to bundle it, but imagine we'd need a different solution. This expects THREE.DRACOLoader so to avoid changing the source code that will get clobbered on the next three.js update, the warnings are muted. For DRACO specifically, I think we can set that in CachedGLTFLoader, rather than modifying GLTFLoader outside of the ES Module changes
| this.model = new Model(); | ||
| this.shadow = new StaticShadow(); | ||
| this.light = new AmbientLight(0xffffff, 1); | ||
| this.light.name = 'AmbientLight'; |
There was a problem hiding this comment.
Was name removed from objects at some point?
There was a problem hiding this comment.
@cdata name is default an empty string, so this helps some debugging
Updates three.js to r98.
lookAtchange in r96 Object3D.lookAt(): support rotated parents mrdoob/three.js#14517Reference Issue
Fixes #147