Express material names in the 3DOM scene graph#1063
Merged
Conversation
elalish
previously approved these changes
Mar 3, 2020
Contributor
elalish
left a comment
There was a problem hiding this comment.
Looks good, just a couple small questions.
packages/3dom/src/context.ts
Outdated
| const port = await this[$workerInitializes]; | ||
| const {port1, port2} = new MessageChannel(); | ||
|
|
||
| console.log(modelGraft?.model.toJSON()); |
Contributor
There was a problem hiding this comment.
Sure you want to keep this?
| const messageEvent = await messageEventArrives; | ||
| console.log(messageEvent.data); | ||
|
|
||
| expect(messageEvent.data).to.be.equal(material.name); |
Contributor
There was a problem hiding this comment.
Does the astronaut have a material name, or are we just checking that empty string equals empty string?
Contributor
Author
There was a problem hiding this comment.
It has a name, I checked... Astronaut_mat, I think
Contributor
There was a problem hiding this comment.
SG; you could add a check that the name is not empty here in the test as documentation.
| // Material names can be safely referenced directly from the Three.js | ||
| // object. | ||
| // @see: https://github.com/mrdoob/three.js/blob/790811db742ea9d7c54fe28f83865d7576f14134/examples/js/loaders/GLTFLoader.js#L2162 | ||
| return (relatedObject as Material).name; |
elalish
approved these changes
Mar 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1062