Skip to content

Cherry-pick fix for IntelliJCoroutines#2843

Merged
jaschdoc merged 4 commits into
mainfrom
fix-intellij-coroutines
Apr 7, 2026
Merged

Cherry-pick fix for IntelliJCoroutines#2843
jaschdoc merged 4 commits into
mainfrom
fix-intellij-coroutines

Conversation

@jaschdoc

@jaschdoc jaschdoc commented Mar 20, 2026

Copy link
Copy Markdown
Collaborator

Cherry-pick of JetBrains/intellij-community@44959e7 but sets the default value to false for canUseIntelliJCoroutines in IntelliJCoroutinesFacade. I have checked with javap that call site(s) are correctly update in dependencies declared with the intellijOriginal configuration in Gradle.

Fixes #2856
Fixes #2825

@jaschdoc jaschdoc force-pushed the fix-intellij-coroutines branch 3 times, most recently from d9399dc to 575b8e0 Compare March 23, 2026 09:50
@jaschdoc jaschdoc marked this pull request as ready for review March 23, 2026 09:56
@jaschdoc jaschdoc requested a review from ting-yuan as a code owner March 23, 2026 09:56
@jaschdoc jaschdoc requested a review from hfmehmed March 23, 2026 09:56
@jaschdoc jaschdoc marked this pull request as draft March 23, 2026 10:28
@jaschdoc jaschdoc force-pushed the fix-intellij-coroutines branch from f26598d to 2ed1043 Compare March 23, 2026 12:18
@jaschdoc jaschdoc marked this pull request as ready for review March 23, 2026 12:18
@ting-yuan

Copy link
Copy Markdown
Contributor

Please revert all runtime dependencies to the coroutine library from intellij's fork to the standard one. Don't forget this on-demand dependency: #2809 (comment)

@jaschdoc jaschdoc force-pushed the fix-intellij-coroutines branch from 2ed1043 to be79496 Compare March 24, 2026 10:57
@jaschdoc jaschdoc force-pushed the fix-intellij-coroutines branch from be79496 to 6a234c0 Compare March 25, 2026 13:06
Comment thread gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KspAATask.kt Outdated
@jaschdoc jaschdoc requested a review from ting-yuan March 26, 2026 09:09
@jaschdoc jaschdoc force-pushed the fix-intellij-coroutines branch from 78ea211 to 561a28d Compare March 26, 2026 09:10
@jaschdoc jaschdoc force-pushed the fix-intellij-coroutines branch from 561a28d to 1daf39f Compare March 26, 2026 09:12
@jaschdoc jaschdoc merged commit e7d08ac into main Apr 7, 2026
3 checks passed
@jaschdoc jaschdoc deleted the fix-intellij-coroutines branch April 7, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin adds maven repo to the project IntelliJ SDK depends on custom fork of kotlinx coroutines

2 participants