Skip to content

Make symbol-processing-api and common-deps compile dependency#2789

Merged
hfmehmed merged 1 commit into
google:mainfrom
hfmehmed:ksp-api-compile-dep
Feb 13, 2026
Merged

Make symbol-processing-api and common-deps compile dependency#2789
hfmehmed merged 1 commit into
google:mainfrom
hfmehmed:ksp-api-compile-dep

Conversation

@hfmehmed

@hfmehmed hfmehmed commented Feb 13, 2026

Copy link
Copy Markdown
Collaborator

To fix #2289

KotlinSymbolProcessing which is on the public API of kotlin-analysis-api module exposes KSPConfig (from -api) and KSPLogger (from -common-deps) so those dependencies should be declared as "compile" for the consumers of the "symbol-processing-aa" published artifact

@jaschdoc jaschdoc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me and makes sense according to the issue but I'm not sure what the "correct" solution is. Maybe wait for @ting-yuan to review? I approve anyway because it seems harmless

@hfmehmed hfmehmed merged commit 73b8dc3 into google:main Feb 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

symbol-processing-aa should have symbol-processing-api as a "compile" dependency, not "runtime"

3 participants