Make symbol-processing-api and common-deps compile dependency#2789
Merged
Conversation
jaschdoc
approved these changes
Feb 13, 2026
jaschdoc
left a comment
Collaborator
There was a problem hiding this comment.
This seems fine to me and makes sense according to the issue but I'm not sure what the "correct" solution is. Maybe wait for @ting-yuan to review? I approve anyway because it seems harmless
ting-yuan
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #2289
KotlinSymbolProcessing which is on the public API of kotlin-analysis-api module exposes KSPConfig (from -api) and KSPLogger (from -common-deps) so those dependencies should be declared as "compile" for the consumers of the "symbol-processing-aa" published artifact