Return static function kind if modifier has static modifier#2411
Merged
Conversation
ting-yuan
reviewed
Apr 11, 2025
| override val functionKind: FunctionKind by lazy { | ||
| if (modifiers.contains(Modifier.JAVA_STATIC)) { | ||
| FunctionKind.STATIC | ||
| } |
Contributor
There was a problem hiding this comment.
Thanks for the fix! Unfortunately getting modifiers can be slow in some cases. Can we patch the when case KaSymbolLocation.CLASS below, and make it consider ktFunctionSymbol.isStatic when it is a KaNamedFunctionSymbol? I.e., something like
KaSymbolLocation.CLASS -> {
if (ktFunctionSymbol is KaNamedFunctionSymbol && ktFunctionSymbol.isStatic)
FunctionKind.STATIC
else
FunctionKind.MEMBER
}
Contributor
Author
There was a problem hiding this comment.
Yeah, looks way better, thank you!
b8679cc to
f391f3b
Compare
ting-yuan
approved these changes
Apr 14, 2025
Contributor
|
Thank you so much for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2410