KSP2: fix the type of vararg for Kotlin sources#2381
Merged
Conversation
Previously, KSValueParameter.type was an array when it is from Kotlin
sources, while it is the declared type for Java and libraries.
For example, the KSValueParameter.type of strings is now consistently
String.
fun (vararg strings: String)
The equivalentJavaWildcards test is updated due to a toString() change.
dx404
approved these changes
Mar 19, 2025
jsjeon
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, KSValueParameter.type was an array when it is from Kotlin sources, while it is the declared type for Java and libraries.
For example, the KSValueParameter.type of strings is now consistently String.
The equivalentJavaWildcards test is updated due to a toString() change.