Skip to content

Filter default arguments by name, not by index #2131

Merged
ting-yuan merged 2 commits into
google:mainfrom
ting-yuan:b2107
Oct 3, 2024
Merged

Filter default arguments by name, not by index #2131
ting-yuan merged 2 commits into
google:mainfrom
ting-yuan:b2107

Conversation

@ting-yuan

Copy link
Copy Markdown
Contributor

KSAnnotation.defaultArguments doesn't have arguments without defaults.
Therefore it can be shorter than KSAnnotation.arguments. Their indexes
may not match.

Fixes #2107

kuanyingchou and others added 2 commits October 3, 2024 11:16
KSAnnotation.defaultArguments doesn't have arguments without defaults.
Therefore it can be shorter than KSAnnotation.arguments. Their indexes
may not match.
@ting-yuan ting-yuan requested a review from dx404 October 3, 2024 18:17
@ting-yuan ting-yuan merged commit 10657b6 into google:main Oct 3, 2024
@ting-yuan ting-yuan deleted the b2107 branch October 11, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[KSP2] Default annotation argument values are sometimes missing

3 participants