Skip to content

Close ksp caches on exception and error#2129

Merged
ting-yuan merged 4 commits into
google:mainfrom
ting-yuan:b2072
Oct 2, 2024
Merged

Close ksp caches on exception and error#2129
ting-yuan merged 4 commits into
google:mainfrom
ting-yuan:b2072

Conversation

@ting-yuan

Copy link
Copy Markdown
Contributor

Previously, LookupCache doesn't need to be explicitly closed. With newer intellij dependencies that comes with Kotlin 2.0.20 it becomes a problem.

Test cases are contributed by @asapha

Fixes #2072

@ting-yuan ting-yuan requested a review from dx404 October 2, 2024 08:04
@google-cla

google-cla Bot commented Oct 2, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Previously, LookupCache doesn't need to be explicitly closed. With newer
intellij dependencies that comes with Kotlin 2.0.20 it becomes a problem.
@ting-yuan ting-yuan merged commit 20e6324 into google:main Oct 2, 2024
@ting-yuan ting-yuan deleted the b2072 branch October 11, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

java.lang.IllegalStateException: Storage for [...] is already registered with 2.0.20-1.0.24

3 participants