recursively substitute functions for compute asMemberOf#1973
Merged
Conversation
22a0125 to
7dbad02
Compare
ting-yuan
reviewed
Jun 18, 2024
| // for functions we need to test both returnType and value parameters converges. | ||
| var funcToSub = (function as KSFunctionDeclarationImpl).ktFunctionSymbol.substitute(it) | ||
| var next = funcToSub.substitute(it) | ||
| while ( |
Contributor
There was a problem hiding this comment.
The complexity of this logic and also its dependency on the substitutor makes me worried whether it always converges. Can you add a counter to throw in case it doesn't?
Contributor
Author
There was a problem hiding this comment.
Sounds fair to me, I thought about the converge issue before but can't think about a fair number to exit.
Contributor
Author
There was a problem hiding this comment.
tentatively put 100 as a safe value.
7dbad02 to
4702102
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1919