Fixes for ZSeries with GCC 9 or earlier or Clang 18 or earlier#2411
Merged
copybara-service[bot] merged 1 commit intogoogle:masterfrom Dec 14, 2024
Merged
Conversation
jan-wassenberg
approved these changes
Dec 13, 2024
Member
jan-wassenberg
left a comment
There was a problem hiding this comment.
Great, thanks for working around the compiler issues :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #2409.
Made fixes to F32->F64 PromoteTo and F64->F32 DemoteTo to work around compiler errors on Z14/Z15 with GCC 8 or GCC 9.
Also made fixes to Reverse on Z14 with GCC 8 to work around the missing vec_reve intrinsic on Z14 with GCC 8 or earlier.
Also marked Z15 target as broken with GCC 8 or earlier as the Z15 target requires GCC 9 or later.
Also marked Z14 and Z15 targets as broken with Clang 18 or earlier due to LLVM bugs in LLVM 18 or earlier on Z14/Z15 that were fixed in LLVM 19, including a bug in LLVM 18 and earlier that was fixed in commit llvm/llvm-project@7e4c6e9 (which made its way into LLVM 19 and later).