[mod_arith] move arith_ext dialect to mod_arith#907
Merged
copybara-service[bot] merged 1 commit intoAug 14, 2024
Conversation
inbelic
commented
Aug 13, 2024
Contributor
Contributor
Author
|
I haven't built this locally with CMake. Is that covered in the workflow here? |
5ba2fb4 to
3cc78f4
Compare
Collaborator
|
The CMake build isn't in the CI yet, but until it is I think it's best effort. Thanks for giving it a go. |
Collaborator
|
If you're not using pre-commit, try applying the patch manually: https://github.com/google/heir/actions/runs/10376987295/job/28774854361?pr=907 |
j2kun
approved these changes
Aug 14, 2024
41e7407 to
40ef2fe
Compare
Contributor
Author
|
Whoops, forgot to re-install pre-commit on my new install. |
40ef2fe to
d65f797
Compare
- originally arith_ext was added to house a couple extra
(modulus-based) operations to help represent the optimizations in
the HEaan.mlir paper
- however, there has been a need for other modular arithmetic
operations and they have been added to the arith_ext dialect
- as such, it was decided to move this to a specific mod_arith
dialect to be more concrete and better describe the operations
d65f797 to
88cc268
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.