Skip to content

add a new arith_ext dialect#711

Merged
copybara-service[bot] merged 1 commit into
google:mainfrom
inbelic:inbelic/arith-ext-dialect
Jun 4, 2024
Merged

add a new arith_ext dialect#711
copybara-service[bot] merged 1 commit into
google:mainfrom
inbelic:inbelic/arith-ext-dialect

Conversation

@inbelic

@inbelic inbelic commented May 31, 2024

Copy link
Copy Markdown
Contributor
  • Add operations barrett_reduce and subifge to mirror the required operations of the HEaan.mlir paper

Resolve #709

@inbelic inbelic force-pushed the inbelic/arith-ext-dialect branch 3 times, most recently from 15d3983 to 266d8fd Compare May 31, 2024 20:41
@inbelic inbelic marked this pull request as ready for review May 31, 2024 20:59
Comment thread lib/Dialect/ArithExt/IR/ArithExtOps.td Outdated
Comment thread lib/Dialect/ArithExt/IR/ArithExtOps.td Outdated
Comment thread lib/Dialect/ArithExt/IR/ArithExtOps.td Outdated
@inbelic inbelic force-pushed the inbelic/arith-ext-dialect branch 2 times, most recently from dd2dec8 to 5d5cbb3 Compare June 3, 2024 03:53
@inbelic

inbelic commented Jun 3, 2024

Copy link
Copy Markdown
Contributor Author

Having worked a bit on the lowerings, I have now also added a verify function to the BarrettReduce operation that ensures the input bitwidth represents the range [0, q^2)

@asraa asraa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some small questions, but looks good to start!

Comment thread lib/Dialect/ArithExt/IR/ArithExtOps.td
Comment thread lib/Dialect/ArithExt/IR/ArithExtDialect.cpp Outdated
  - Add operations barrett_reduce and subifge to mirror the required
    operations of the HEaan.mlir paper
@inbelic inbelic force-pushed the inbelic/arith-ext-dialect branch from 5d5cbb3 to 1f41a17 Compare June 3, 2024 17:49

@asraa asraa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @inbelic !

@asraa asraa added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Jun 3, 2024
@copybara-service copybara-service Bot merged commit 5fcdf30 into google:main Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a new dialect arith_ext

3 participants