poly: add ntt and intt ops#570
Merged
Merged
Conversation
Contributor
Author
|
Not quite happy with the summary and description of the operations. Would like feedback on those |
asraa
approved these changes
Mar 28, 2024
asraa
left a comment
Collaborator
There was a problem hiding this comment.
Thank you so much! Just a couple of nits, feel free to take the suggestions as you like.
j2kun
approved these changes
Mar 28, 2024
5bd3bdc to
cb5c66a
Compare
Contributor
Author
|
Sweet, thanks for the great review and suggestions! |
- Intoduce ntt/intt ops that convert them to/from tensors with their
ideal ring attributes encoded
- These tensors allow for the polynomial to be in the corresponding
point-value representation for more efficient polynomial
multiplicaiton
Resolves google#182
cb5c66a to
9df52df
Compare
j2kun
approved these changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #182